This repository was archived by the owner on Jun 13, 2024. It is now read-only.
Draft
Conversation
added 5 commits
June 13, 2022 16:59
Remove LinearAlgebra for now
Member
cedricchevalier19
left a comment
cedricchevalier19
left a comment
There was a problem hiding this comment.
C++ comments. Nothing deeper yet.
| #include <alien/kernels/simple_csr/SimpleCSRBackEnd.h> | ||
|
|
||
| #include <alien/hypre/backend.h> | ||
| #include "../../include/alien/hypre/backend.h" |
| #include <alien/kernels/simple_csr/SimpleCSRBackEnd.h> | ||
|
|
||
| #include <alien/hypre/backend.h> | ||
| #include "../../include/alien/hypre/backend.h" |
| LinearSolverFactory(const BackEnd::Options& options) | ||
| { | ||
| return std::make_shared<LinearAlgebra>(); | ||
| return new PluginLinearSolver(options); |
Member
There was a problem hiding this comment.
Using unique_ptr or shared_ptr allows to not expose that we use new and takes care of properly deleting.
added 8 commits
June 22, 2022 14:35
Also throw exception on Multi[Matrix,Vector]Impl::getImpl if backend not found
member definition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test for CD/CI
Will squash all commits later