externalize: skip submodules not invoked in the exported graph#18
Merged
gokulkrishna98 merged 3 commits intoJun 17, 2026
Merged
Conversation
When a model registers a submodule whose class matches an externalize_modules target but the model's forward never calls it, the re-exported FX graph contains no custom-op node for that submodule. The pipeline previously raised ``ValueError: Custom op for '<name>' not found in any ancestor program`` from _find_program_for, aborting the whole conversion. Skip these submodules (with a UserWarning) instead. The unused module's forward is still restored by _restore_externalized. Also silence pre-existing F821 lint warnings on transform_with_custom_compression_ops references in skipped tests so pre-commit ruff-check passes.
gokulkrishna98
changed the title
gokulkrishna98
requested review from
DawerG,
Lewis300,
YifanShenSZ,
cymbalrush and
srjoglekar246
DawerG
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
from _find_program_for and aborting the entire conversion.
Fix:
Skip such submodules with a UserWarning instead of raising. The unused module's forward is still restored by
_restore_externalized.
Also silences pre-existing F821 lint warnings on transform_with_custom_compression_ops references in skipped tests so pre-commit ruff-check passes.
Testing