SOLR-18044 EssentialSolrRequestFilter to perform non-optional request wrapping operations #3997
Conversation
… wrapping operations required for proper functioning of Solr
|
Hmm This change essentially consumes the changes from SOLR-18042, but the build is complaining when I remove the (now inaccurate/misleading) entry for SOLR-18042 ... What's the intended method to handle something that changes twice before a release? |
The changelog checker script does not anticipate a removal. Should probably allow the case where a yml is deleted. I'll prepare a fix. For this PR you can simply ignore the failure and merge :) |
|
See #3999 for proposed change... |
changelog/unreleased/SOLR-18044.yml
Outdated
| @@ -0,0 +1,8 @@ | |||
| # See https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc | |||
| title: SOLR 18044 - EssentialSolrRequestFilter has been added to perform non-optional request wrapping operations required for proper functioning of Solr | |||
There was a problem hiding this comment.
Please don't include JIRA number in Title, it is redundant with the links below which will anyway be rendered into CHANGES.md automatically
There was a problem hiding this comment.
Ah ok, it arrived via the generation so I left it. Will fix
2 participants
https://issues.apache.org/jira/browse/SOLR-18044
The operations in this filter are expected to be required for proper functioning of Solr, and it should not contain anything that could reasonably be removed, or replaced with an alternate configuration.
For the moment this is replacing MDC filter since we seem to have actually made a few portions of the solr code dependent on it. Depending on how SOLR-18050 is resolved we might re-extract MDC from the rest of this.