[CI] Add pre-commit hook checkmake to lint Makefiles#2751
Merged
jiayuasu merged 1 commit intoapache:masterfrom Mar 16, 2026
Merged
[CI] Add pre-commit hook checkmake to lint Makefiles#2751jiayuasu merged 1 commit intoapache:masterfrom
jiayuasu merged 1 commit intoapache:masterfrom
Conversation
Added 3 hooks: - checkmake (root): with custom checkmake.ini - checkmake (python/sedona/doc): with custom checkmake.ini - insert-license: to auto insert license headers for ini files Slightly relaxed config for phony target body "lengths" Cleaned up the root Makefile removing the missing "test" target and adding "run-docs" target to the phony list https://github.com/checkmake/checkmake https://github.com/checkmake/checkmake?tab=readme-ov-file#pre-commit-usage https://en.wikipedia.org/wiki/INI_file#Comments
jiayuasu
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added 3 hooks:
Slightly relaxed config for phony target body "lengths"
Cleaned up the root Makefile removing the missing "test" target and adding "run-docs" target to the phony list
https://github.com/checkmake/checkmake
https://github.com/checkmake/checkmake?tab=readme-ov-file#pre-commit-usage
https://en.wikipedia.org/wiki/INI_file#Comments
Did you read the Contributor Guide?
Is this PR related to a ticket?
[CI] my subjectWhat changes were proposed in this PR?
Added 3 more hooks to our pre-commit framework.
Using checkmake—a static analysis linter for Makefiles—provides several benefits centered on maintaining build script quality and reliability.
The primary advantages of using this tool include:
How was this patch tested?
With pre-commit
Did this PR include necessary documentation updates?