Skip to content

[CI] Add pre-commit hook vulture to find dead Python code#1628

Draft
jbampton wants to merge 7 commits intoapache:masterfrom
jbampton:add-pre-commit-hook-vulture
Draft

[CI] Add pre-commit hook vulture to find dead Python code#1628
jbampton wants to merge 7 commits intoapache:masterfrom
jbampton:add-pre-commit-hook-vulture

Conversation

@jbampton
Copy link
Member

@jbampton jbampton commented Oct 11, 2024

https://github.com/jendrikseipp/vulture?tab=readme-ov-file#configuration

https://github.com/jendrikseipp/vulture?tab=readme-ov-file#integrations

https://github.com/jendrikseipp/vulture?tab=readme-ov-file#flake8-noqa-comments

https://stackoverflow.com/questions/5033727/how-do-i-get-pyflakes-to-ignore-a-statement

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

  • No

What changes were proposed in this PR?

Added another check/test to our pre-commit framework.

Cleaned up some Python code.

How was this patch tested?

Ran locally: pre-commit run --all-files

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the documentation.

@jbampton jbampton marked this pull request as ready for review October 12, 2024 00:54
@jbampton jbampton requested a review from jiayuasu as a code owner October 12, 2024 00:54
@jbampton jbampton marked this pull request as draft October 12, 2024 06:37
@jbampton jbampton self-assigned this Oct 29, 2024
@jbampton jbampton added the pre-commit Pull requests that update pre_commit code label Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pre-commit Pull requests that update pre_commit code root sedona-python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant