[Studio][fix] Preserve SSE framing for AI chat#438
Open
btlqql wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contentpayload and the server stub'stextpayload[DONE]sentinelRoot cause
chatStreamsplit every network chunk on newlines and parsed it immediately.ReadableStreamchunks do not preserve SSE event boundaries, so JSON split between chunks was treated as malformed raw text. The client also ignored thetextfield emitted byLlmGatewayStub.Impact
AI responses are no longer lost or corrupted when an event is split or combined by the network, and the bundled backend stub now matches the frontend stream consumer.
Validation
cd web && npm test— 9 tests passedcd web && npm run build— passedcd web && npm run lint— 0 errors; 3 pre-existing warnings in unrelated filesFixes #437