IGNITE-27620 Disable pager on Windows by default #7469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Windows 'more' command doesn't support ANSI color codes well, causing garbled output when paging through colored CLI output. Change the default pager behavior: - Windows: disabled by default - Other platforms: enabled by default (uses 'less -RFX') Users can still explicitly enable/disable pager via config: cli config set ignite.cli.pager.enabled=true 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Tests verify that: - Pager is disabled by default on Windows - Pager is enabled by default on Linux/macOS - Explicit config overrides the default 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Replace system property manipulation with JUnit 5 OS condition annotations for cleaner, more idiomatic tests. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
morecommand doesn't support ANSI color codes wellless -RFXcli config set ignite.cli.pager.enabled=true/falseJira: https://issues.apache.org/jira/browse/IGNITE-27620
Test plan
🤖 Generated with Claude Code