Ignite 24467 #7445
Open
Ignite 24467 #7445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgorKuts
force-pushed
the
ignite-24467
branch
from
26719c2 to
e6f6aa3
Compare
alievmirza
reviewed
Jan 27, 2026
|
|
||
| /** Constructor. */ | ||
| public AssignmentsQueue(AssignmentsQueue... assignmentsQueues) { | ||
| LinkedList<Assignments> assigments = new LinkedList<>(); |
| assertValuesPresentOnNodes(node.clock().now(), table, 0, 1, 2); | ||
|
|
||
| stopNodes(1, 2); | ||
|
|
Contributor
There was a problem hiding this comment.
assertLogicalTopologyInMetastorage(List.of(0, 3, 4, 5), node);
| // Check that there is no ongoing or planned rebalance. | ||
| assertNull(getPendingAssignments(node0, partId)); | ||
|
|
||
| assertRealAssignments(node0, partId, 1); |
Contributor
There was a problem hiding this comment.
let's also check scenario when offline nodes where filtered (in this case, node 2 also was removed)
| .target(Assignments.forced(Set.of(nextAssignment), assignmentsTimestamp)) | ||
| .toQueue(); | ||
|
|
||
| if (!manualUpdate) { |
Contributor
There was a problem hiding this comment.
Let think about this zhopniy scenario
A(10), B(10), C(6)
A, B left
C leader -> we have pending realance that include A or B [A, B, C, E(0)]
C accepts some data -> C(10')
A, B restarted, they wont clean up their data
A(10), B(10), C(10'), E(10')
Contributor
Author
There was a problem hiding this comment.
If A and B are left by the reset revision, they won’t be put into pending. When they start and recover, they will be destroyed.
If A and B are not left by the reset revision, they will win the election and become leader instead of C.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HA reset overwrites ongoing rebalance caused by the distribution zone filter change. Solution: append existing pendings to assigment queue during reset.
https://issues.apache.org/jira/browse/IGNITE-24467