-
Notifications
You must be signed in to change notification settings - Fork 421
sync cibuildwheel test env with uv #2913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I wasnt able to run #2912 since the branch was not on the apache repo. Just pushed this branch to the apache repo and ran the nightly CI with the branch https://github.com/apache/iceberg-python/actions/runs/21004675670 |
|
Awesome, it worked https://github.com/apache/iceberg-python/actions/runs/21005261083 |
|
cc @nssalian |
|
Thanks for the fix @kevinjqliu . Looks good. |
|
Why do Wouldnt that differ vs the lockfile? I come from a mostly pdm background so unsure exactly whats happening but assuming the semantics are at least similar |
|
good point @jayceslesar let me try that |
This reverts commit 2be8927.
geruh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Rationale for this change
Follow up to #2912
CI still fails with
https://github.com/apache/iceberg-python/actions/runs/21004478697/job/60383069033
This PR fixes syncs the env with uv so we dont need to explicitly specify the deps here
Are these changes tested?
Yes
https://github.com/apache/iceberg-python/actions/runs/21007310527
Are there any user-facing changes?