Skip to content

Conversation

@kevinjqliu
Copy link
Contributor

@kevinjqliu kevinjqliu commented Jan 14, 2026

Rationale for this change

Follow up to #2912

CI still fails with
https://github.com/apache/iceberg-python/actions/runs/21004478697/job/60383069033

Error: cibuildwheel: Command ['C:\\Users\\runneradmin\\AppData\\Local\\Temp\\cibw-run-0tbpuziz\\cp310-win_amd64\\venv-test\\Scripts\\pip.EXE', 'install', 'pytest==7.4.2', 'moto==5.0.1', 'pytest-lazy-fixture==0.6.3', 'sqlalchemy>=2.0.18,<3'] failed with code 1. 

Error: Process completed with exit code 1.

This PR fixes syncs the env with uv so we dont need to explicitly specify the deps here

Are these changes tested?

Yes
https://github.com/apache/iceberg-python/actions/runs/21007310527

Are there any user-facing changes?

@kevinjqliu
Copy link
Contributor Author

I wasnt able to run #2912 since the branch was not on the apache repo. Just pushed this branch to the apache repo and ran the nightly CI with the branch https://github.com/apache/iceberg-python/actions/runs/21004675670

@kevinjqliu kevinjqliu changed the title fix quoting sync cibuildwheel test env with uv Jan 14, 2026
@kevinjqliu kevinjqliu mentioned this pull request Jan 14, 2026
3 tasks
@kevinjqliu kevinjqliu requested a review from Fokko January 14, 2026 18:34
@kevinjqliu
Copy link
Contributor Author

Awesome, it worked https://github.com/apache/iceberg-python/actions/runs/21005261083

@kevinjqliu
Copy link
Contributor Author

cc @nssalian

@nssalian
Copy link
Contributor

Thanks for the fix @kevinjqliu . Looks good.

@jayceslesar
Copy link
Contributor

jayceslesar commented Jan 14, 2026

Why do uv pip install --group dev instead of uv sync --group dev ?

Wouldnt that differ vs the lockfile? I come from a mostly pdm background so unsure exactly whats happening but assuming the semantics are at least similar

@kevinjqliu
Copy link
Contributor Author

good point @jayceslesar let me try that

@kevinjqliu
Copy link
Contributor Author

that works! https://github.com/apache/iceberg-python/actions/runs/21007310527

Copy link
Contributor

@geruh geruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants