HBASE-30037: FullTableBackupClient should not delete bulk load tracking entries before backup completion#7994
Open
nazuhifu wants to merge 1 commit intoapache:masterfrom
Open
HBASE-30037: FullTableBackupClient should not delete bulk load tracking entries before backup completion#7994nazuhifu wants to merge 1 commit intoapache:masterfrom
nazuhifu wants to merge 1 commit intoapache:masterfrom
Conversation
…ng entries before backup completion
vaijosh
reviewed
Mar 28, 2026
| backupManager | ||
| .deleteBulkLoadedRows(bulkLoadsToDelete.stream().map(BulkLoad::getRowKey).toList()); | ||
| } catch (Exception e) { | ||
| failBackup(conn, backupInfo, backupManager, e, "Unexpected BackupException : ", |
Contributor
There was a problem hiding this comment.
Hi @nazuhifu
What happens if the backup completes successfully but a failure occurs during the deleteBulkLoadedRows call? In that case, it appears the operation is reported as a BackupFailure, even though the backup itself succeeded and only the post-cleanup step failed.
Can we improve this behavior to distinguish between backup success and cleanup failure?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: HBASE-30037
Move deleteBulkLoadedRows() to execute only after completeBackup() so bulk load tracking rows are removed only when the full backup has completed successfully
Add regression test to ensure bulk load tracking rows are not removed if full backup fails