[flink] changelog read support for pk table without pushdown optimizations #2347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Great! Thank you @MehulBatra , I will review it. |
wuchong
reviewed
Jan 18, 2026
Member
wuchong
left a comment
wuchong
left a comment
There was a problem hiding this comment.
Thanks @MehulBatra for the contribution. I left some comments.
...ss-flink-common/src/test/java/org/apache/fluss/flink/source/ChangelogVirtualTableITCase.java
Show resolved
Hide resolved
...ss-flink-common/src/test/java/org/apache/fluss/flink/source/ChangelogVirtualTableITCase.java
Show resolved
Hide resolved
...ss-flink-common/src/test/java/org/apache/fluss/flink/source/ChangelogVirtualTableITCase.java
Show resolved
Hide resolved
...ss-flink-common/src/test/java/org/apache/fluss/flink/source/ChangelogVirtualTableITCase.java
Show resolved
Hide resolved
...fluss-flink-common/src/main/java/org/apache/fluss/flink/utils/RecordToFlinkRowConverter.java
Show resolved
Hide resolved
fluss-server/src/main/java/org/apache/fluss/server/utils/TableDescriptorValidation.java
Show resolved
Hide resolved
...nk-1.20/src/test/java/org/apache/fluss/flink/source/Flink120ChangelogVirtualTableITCase.java
Show resolved
Hide resolved
Comment on lines
+404
to
+408
| // Parse the row to validate structure | ||
| String[] parts = result.substring(3, result.length() - 1).split(", ", 6); | ||
|
|
||
| // Validate change type column | ||
| assertThat(parts[0]).isEqualTo("+I"); |
Member
There was a problem hiding this comment.
We can set ManualClock to the FlussClusterExtension to control the commit timestamp by setting the current time CLOCK.advanceTime(xxxxx, TimeUnit.MILLISECONDS), see the usage in FlinkTableSourceITCase.
In this way, we can assert the changelog result by comparing the whole row string. (set bucket to 1 to have consistent log_offset numbers)
| /** | ||
| * Creates a virtual $changelog table by modifying the base table's to include metadata columns. | ||
| */ | ||
| private CatalogBaseTable getVirtualChangelogTable(ObjectPath objectPath) |
Member
There was a problem hiding this comment.
Please add tests in FlinkCatalogITCase to assert the CatalogTable got from a $changelog table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #2333
Brief change log
File: ChangelogFlinkTableSource.java
Purpose: Flink table source for $changelog virtual tables
────────────────────────────────────────
File: ChangelogDeserializationSchema.java
Purpose: Deserializes LogRecord → RowData with metadata
────────────────────────────────────────
File: ChangelogRowConverter.java
Purpose: Converts records, adds _change_type, _log_offset,
commit_timestamp
────────────────────────────────────────
File: RecordToFlinkRowConverter.java
Purpose: Interface for record converters
────────────────────────────────────────
File: FlinkTableFactory.java
Change: Routes to ChangelogFlinkTableSource for changelog
tables
────────────────────────────────────────
File: TableDescriptor.java
Change: Added CHANGELOG* column name constants
────────────────────────────────────────
File: TableDescriptorValidation.java
Change: Validates reserved column names
Test Coverage
Test: testChangelogVirtualTableSchema
Type: Schema
What it verifies: DESCRIBE shows correct columns
────────────────────────────────────────
File: FlinkCatalog.java
Change: Detects $changelog suffix, builds virtual table
schema
Tests
File: ChangelogVirtualTableITCase.java
Purpose: Integration tests (7 tests)
────────────────────────────────────────
File: ChangelogRowConverterTest.java
Purpose: Unit tests for converter
────────────────────────────────────────
API and Format
Documentation