Fix nil listener callback - #137
Merged
AlexStocks merged 2 commits intoJul 20, 2026
Merged
Conversation
AlexStocks
approved these changes
Jul 20, 2026
|
这个问题,给上游 alexstocks/getty 也来个 PR @222twotwotwo |
Author
done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
handlePackageerror cleanup by requiring both session and listener before callingOnErrorOnClosewhen the listener is nil so the same cleanup path does not panic one line laterWhich issue(s) this PR fixes:
Fixes #132
Special notes for your reviewer:
The cleanup path used
s != nil || s.listener != nil, so a non-nil session with a nil listener still attempted to calls.listener.OnError(...)and could panic while handling an existing read/decode error.Does this PR introduce a user-facing change?: