refactor(JS: explicitly using TerminalNode): move the implementation to TerminalNode/ErrorNode and actually use them.#4933
Open
jerry4718 wants to merge 1 commit into
Open
Conversation
…n to `TerminalNode`/`ErrorNode` and actually use them. - add an abstract `accept()` method to the `ParseTree` base class. - remove `ErrorNodeImpl` and `TerminalNodeImpl`, use direct class implementations. - update `Parser`, `ParserRuleContext`, and `ParseTreeWalker` to use instanceof checks. Signed-off-by: jerry4718 <jerry4718@qq.com>
jerry4718
force-pushed
the
dev-use-direct-TerminalNode
branch
from
9ec4cbe to
959c891
Compare
Author
|
The type export and declaration are based on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
accept()method to theParseTreebase class.ErrorNodeImplandTerminalNodeImpl, use direct class implementations.Parser,ParserRuleContext, andParseTreeWalkerto use instanceof checks.