Conversation
prmukherj
requested review from
hpohekar,
mayankansys,
mkundu1 and
seanpearsonuk
as code owners
There was a problem hiding this comment.
Pull request overview
This PR fixes missing TLS-related arguments in the StandaloneLauncher class by adding certificates_folder and insecure_mode parameters to enable proper certificate configuration for Fluent's gRPC server.
- Added
certificates_folderparameter to specify TLS certificate location - Added
insecure_modeparameter to enable non-TLS gRPC connections
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Although these modes are not required for standalone launch, it is OK to add them as they are supported. Some user may look for a common script for different launch modes. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Based on your comment, I would phrase it as necessary to add them. |
| import ansys.fluent.core as pyfluent | ||
|
|
||
| self.certificates_folder = certificates_folder | ||
| self.insecure_mode = insecure_mode |
There was a problem hiding this comment.
How are these arguments passed to Fluent or used in the client during the channel construction?
|
Please update the |
Pull request was converted to draft
|
Converted this to draft for further testing the Standalone mode. cc. @seanpearsonuk, @mkundu1. |
Context
'certificates_folder' and 'insecure_mode' was missing in 'StandaloneLauncher'
Change Summary
'certificates_folder' and 'insecure_mode' were added as launcher args.
Impact
'certificates_folder' and 'insecure_mode' will be exposed.