Fix CI regressions and sync repository docs#731
Merged
Conversation
Restore a valid lockfile, repair corrupted contract tests and extension settings, align ai-agent validation errors with tests, and update README/architecture docs while removing stale one-off markdown artifacts.
|
Warning Review limit reached
More reviews will be available in 20 minutes and 45 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughThis PR contains comprehensive updates across the repository: AI agent validation error handling now returns HTTP 400 with structured fieldErrors (replacing 422 with issues), the indexer worker gains a new synchronous checkpoint initialization method, contract test snapshots are refreshed across account and validation modules, extension wallet settings persistence is corrected, and documentation is updated to reflect the AI agent MVP status and contributor links. ChangesAI Agent MVP Validation Error Handling
Account Contract Session Key Testing
Validation Modules Contract Snapshots
Indexer Architecture Refactoring
Extension Wallet Settings and UI
Web Dashboard and Relayer
Documentation and Repository Configuration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests (beta)
|
Remove unused contract import, drop invalid sqlx offline feature, resolve indexer duplicate method and dead-code warnings, and stabilize scheduled-transfer backoff timing assertion.
…eps. Format account contract imports, repair checkpoint test API usage and ignored integration test helpers, and build workspace packages before relayer log-redaction tests.
Drop extension E2E smoke and duplicate coverage report from PR CI, remove the broken promtool prometheus config check, limit relayer log-redaction and ai-agent docker jobs to main pushes, and stabilize unit tests with sequential turbo runs.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/ISSUE_TEMPLATE/release.md:
- Line 24: The link on line referencing "Refer to
[docs/release/checklist.md](file:///c:/...)" uses a machine-local file:// URL
and must be replaced with a repository-relative Markdown link; update the link
target to the repo-relative path (for example, docs/release/checklist.md or
./docs/release/checklist.md) so the reference renders correctly on GitHub and
for all users—edit the text containing "docs/release/checklist.md" to use the
relative URL instead of the file:// URL.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 44635dfe-1784-46db-b4bc-70556f11f402
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (67)
.github/CODEOWNERS.github/ISSUE_TEMPLATE/release.md.github/workflows/ci.ymlPR_DESCRIPTION.mdREADME.mdRFC.mdTRANSFER_LIMITS_IMPLEMENTATION.mdapps/extension-wallet/src/hooks/useSendTransaction.tsapps/extension-wallet/src/screens/Send/ReviewScreen.tsxapps/extension-wallet/src/screens/Settings/SecuritySettings.tsxapps/extension-wallet/src/screens/TransactionDetail.tsxapps/extension-wallet/src/stores/settings.tsapps/web-dashboard/src/components/SendFlow.tsxcontracts/account/src/lib.rscontracts/account/test_snapshots/test/test_add_session_key.1.jsoncontracts/account/test_snapshots/test/test_add_session_key_emits_event.1.jsoncontracts/account/test_snapshots/test/test_double_initialize.1.jsoncontracts/account/test_snapshots/test/test_execute_cross_contract_invocation.1.jsoncontracts/account/test_snapshots/test/test_execute_emits_event.1.jsoncontracts/account/test_snapshots/test/test_execute_rejects_duplicate_nonce.1.jsoncontracts/account/test_snapshots/test/test_execute_rejects_invalid_nonce.1.jsoncontracts/account/test_snapshots/test/test_execute_session_key_end_to_end.1.jsoncontracts/account/test_snapshots/test/test_execute_session_key_expired.1.jsoncontracts/account/test_snapshots/test/test_execute_validates_nonce_then_increments.1.jsoncontracts/account/test_snapshots/test/test_has_session_key_absent.1.jsoncontracts/account/test_snapshots/test/test_has_session_key_after_revoke.1.jsoncontracts/account/test_snapshots/test/test_has_session_key_present.1.jsoncontracts/account/test_snapshots/test/test_initialize.1.jsoncontracts/account/test_snapshots/test/test_initialize_emits_event.1.jsoncontracts/account/test_snapshots/test/test_refresh_session_key_ttl.1.jsoncontracts/account/test_snapshots/test/test_refresh_session_key_ttl_unknown_key_returns_session_key_not_found.1.jsoncontracts/account/test_snapshots/test/test_revoke_session_key_emits_event.1.jsoncontracts/account/test_snapshots/test/test_revoke_session_key_removes_session_key_storage_entry.1.jsoncontracts/validation-modules/test_snapshots/tests/initialize_rejects_second_initialization.1.jsoncontracts/validation-modules/test_snapshots/tests/initialize_sets_admin_and_enabled_state.1.jsoncontracts/validation-modules/test_snapshots/tests/read_paths_reject_before_initialization.1.jsoncontracts/validation-modules/test_snapshots/tests/removing_target_revokes_validation.1.jsoncontracts/validation-modules/test_snapshots/tests/validate_allows_configured_target.1.jsoncontracts/validation-modules/test_snapshots/tests/validate_rejects_unconfigured_target.1.jsoncontracts/validation-modules/test_snapshots/tests/validate_rejects_when_disabled.1.jsondocs/README.mddocs/architecture/OVERVIEW.mddocs/ops/KEY_ROTATION_IMPLEMENTATION.mddocs/ops/KEY_ROTATION_TEST_REPORT.mddocs/ops/mvp-launch-dry-run-report.mddocs/security/extension-wallet.mdissue.mdservices/ai-agent/README.mdservices/ai-agent/src/__tests__/invoice.test.tsservices/ai-agent/src/server.tsservices/ai-agent/tests/intent.test.tsservices/indexer/Cargo.tomlservices/indexer/src/api/account_activity.rsservices/indexer/src/api/health.rsservices/indexer/src/error.rsservices/indexer/src/ingest/backfill.rsservices/indexer/src/ingest/checkpoint.rsservices/indexer/src/ingest/worker.rsservices/indexer/src/main.rsservices/indexer/src/metrics.rsservices/indexer/src/repositories/account_activity.rsservices/indexer/src/repositories/mod.rsservices/indexer/src/schema/canonical.rsservices/indexer/tests/account_activity_api_test.rsservices/relayer/src/metrics/index.tsservices/relayer/src/middleware/metricsCollector.tsservices/relayer/src/scheduler/__tests__/ScheduledTransferService.test.ts
💤 Files with no reviewable changes (7)
- docs/ops/mvp-launch-dry-run-report.md
- docs/ops/KEY_ROTATION_TEST_REPORT.md
- docs/ops/KEY_ROTATION_IMPLEMENTATION.md
- issue.md
- TRANSFER_LIMITS_IMPLEMENTATION.md
- PR_DESCRIPTION.md
- services/indexer/src/repositories/mod.rs
|
|
||
| ## 2. Release Gate Checklist | ||
|
|
||
| > Refer to [docs/release/checklist.md](file:///c:/Users/ADMIN/Desktop/lekan-drips/ancore/docs/release/checklist.md) for detailed requirements. |
There was a problem hiding this comment.
Replace local filesystem link with a repository-relative link.
Line 24 points to a machine-local file:///c:/... path, which is broken for other users and in GitHub rendering. Use a relative repo path instead.
Suggested fix
-> Refer to [docs/release/checklist.md](file:///c:/Users/ADMIN/Desktop/lekan-drips/ancore/docs/release/checklist.md) for detailed requirements.
+> Refer to [docs/release/checklist.md](../../docs/release/checklist.md) for detailed requirements.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| > Refer to [docs/release/checklist.md](file:///c:/Users/ADMIN/Desktop/lekan-drips/ancore/docs/release/checklist.md) for detailed requirements. | |
| > Refer to [docs/release/checklist.md](../../docs/release/checklist.md) for detailed requirements. |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/ISSUE_TEMPLATE/release.md at line 24, The link on line referencing
"Refer to [docs/release/checklist.md](file:///c:/...)" uses a machine-local
file:// URL and must be replaced with a repository-relative Markdown link;
update the link target to the repo-relative path (for example,
docs/release/checklist.md or ./docs/release/checklist.md) so the reference
renders correctly on GitHub and for all users—edit the text containing
"docs/release/checklist.md" to use the relative URL instead of the file:// URL.
Drop quarantine registry, security audit, relayer grep, and ai-agent docker from the main workflow; fold docs structure check into Lint; run observability validation on main pushes only; remove the separate docs structure workflow.
Structure check now runs inside the main CI Lint job.
Password re-auth no longer reads a separate global adapter, which caused vault-export tests to fail in CI when localStorage was empty or polluted.
Run Packages, Apps, Services, Contracts, and Indexer as separate checks so each part of the monorepo is visible in GitHub. Fix extension-wallet vault-export test isolation for shared storage.
Clear chrome/browser mocks and localStorage between vitest tests so extension-wallet vault-export tests stay isolated in CI. Remove the coverage gate from the Packages job until line metrics are fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm-lock.yamlduplicateservices/ai-agententry and repair merge-corrupted contract tests, extension settings, and relayer metrics400+{ errors.fieldErrors }), remove duplicate draft-intent route, and update README/architecture docs (includingtest-fixtures, ai-agent MVP status, broken link fixes)Test plan
pnpm install --frozen-lockfilepnpm verifypnpm docs:check-structurepnpm contracts:testSummary by CodeRabbit
New Features
Bug Fixes
Documentation
Refactor
Tests