clean up and deduplicate code#9
Open
kylon wants to merge 5 commits into
Open
Conversation
remove deprecated dkms option fix codename switch mismatch (that's the problem with duplicated code) fix codename sysfs showing the enum value instead of the actual codename replaced the mess of gotos with linear code general clean up and readability/consistency
CkNoSFeRaTU
reviewed
Jun 4, 2025
merge leftover up version to 0.1.8 update README.md sort IDs move smu_common to lib
CkNoSFeRaTU
reviewed
Jun 5, 2025
AlxHnr
reviewed
Jun 5, 2025
AlxHnr
reviewed
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove deprecated dkms option
fix codename switch mismatch (that's the problem with duplicated code)
replaced the mess of gotos with linear code
general clean up and readability/consistency