feat: implement Adoption Lifecycle State Machine (Issue #59)#109
Merged
amina69 merged 1 commit intoMay 30, 2026
Merged
Conversation
- Create AdoptionStateMachine service with explicit transition map - Create DomainException for invalid domain transitions - Enforce state machine in AdoptionService.updateAdoptionStatus - Enforce state machine in EscrowService.releaseEscrow - Add comprehensive unit tests covering all valid/invalid transitions - Update module imports to wire all dependencies
|
@middalukawunti-lang Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the Adoption Lifecycle State Machine as specified in Issue #59. This enforces strict domain integrity by controlling valid Adoption.status transitions and preventing invalid lifecycle mutations.
Changes
New Files
src/common/exceptions/domain.exception.ts- DomainException (HTTP 422) for invalid domain transitionssrc/adoption/services/adoption-state-machine.service.ts- State machine service with explicit transition mapsrc/adoption/services/adoption-state-machine.service.spec.ts- Comprehensive unit tests for all transitionsModified Files
src/adoption/adoption.service.ts- Enforce state machine before every status updatesrc/adoption/adoption.service.spec.ts- Add state machine mock and test for blocked invalid transitionssrc/adoption/adoption.module.ts- Register and export AdoptionStateMachinesrc/escrow/escrow.service.ts- Enforce adoption must be ESCROW_FUNDED before releasing escrowsrc/escrow/escrow.service.spec.ts- Add state machine mocksrc/escrow/escrow.module.ts- Import AdoptionModule for AdoptionStateMachine accessValid Transitions
Testing
Closes #59