Skip to content

Enum datatypes implementation#41

Merged
guillaume-alliander merged 9 commits into
alliander-opensource:mainfrom
tom-hg57:enum-datatypes-implementation
Sep 2, 2025
Merged

Enum datatypes implementation#41
guillaume-alliander merged 9 commits into
alliander-opensource:mainfrom
tom-hg57:enum-datatypes-implementation

Conversation

@tom-hg57
Copy link
Copy Markdown
Contributor

@tom-hg57 tom-hg57 commented Mar 4, 2025 •
edited
Loading

  • Update generated modernpython sources created by cimgen (https://github.com/sogno-platform/cimgen/tree/master)
  • Fix ruff warnings
  • Rename and adapt writer tests acc. to renamed writer.py to chevron_writer.py
  • Fix test_load_all.py for Primitive, CIMDatatype, EnumType
  • Fix json_dump error by setting attribute_class as str
  • Fix type check errors
  • Change required python version to 3.11 (for enum.EnumType)
  • Increase version number
  • Update examples for custom attributes, profiles, and namespaces in README.md

tom-hg57 and others added 8 commits March 4, 2025 23:24
@tom-hg57
Update generated modernpython sources created by cimgen (https://gith…
2b8a3cf 
…ub.com/sogno-platform/cimgen/tree/master)

Signed-off-by: Thomas Günther <tom@toms-cafe.de>
@tom-hg57
Fix ruff warnings
19094b6 
Signed-off-by: Thomas Günther <tom@toms-cafe.de>
@tom-hg57
Rename and adapt writer tests acc. to renamed writer.py to chevron_wr…
8c1dd6b 
…iter.py

Signed-off-by: Thomas Günther <tom@toms-cafe.de>
@tom-hg57
Fix test_load_all.py for Primitive, CIMDatatype, EnumType
d663960 
Signed-off-by: Thomas Günther <tom@toms-cafe.de>
@HUG0-D @tom-hg57
Fix json_dump error by setting attribute_class as str
9e0c27c 
Signed-off-by: HUG0-D <hugo.delesalle@zaphiro.ch>
@tom-hg57
Fix type check errors
25605ce 
Signed-off-by: Thomas Günther <tom@toms-cafe.de>
@tom-hg57
Change required python version to 3.11 (for enum.EnumType)
33113fe 
Signed-off-by: Thomas Günther <tom@toms-cafe.de>
@tom-hg57
Increase version number
ddd4523 
Signed-off-by: Thomas Günther <tom@toms-cafe.de>
@guillaume-alliander
Copy link
Copy Markdown
Collaborator

guillaume-alliander commented May 27, 2025

Sorry for the delay, @tom-hg57 . Looks good to me, thanks!

@tom-hg57
Copy link
Copy Markdown
Contributor Author

tom-hg57 commented May 28, 2025

If it has been approved, it could be merged, couldn't it?
I don't have the authorisation to merge.

@tom-hg57
Update examples for custom attributes, profiles, and namespaces in RE…
318f466 
…ADME.md

Signed-off-by: Thomas Günther <tom@toms-cafe.de>
@tom-hg57 tom-hg57 mentioned this pull request Jun 8, 2025
Open
@guillaume-alliander guillaume-alliander merged commit 0fe5269 into alliander-opensource:main Sep 2, 2025
2 checks passed
@tom-hg57 tom-hg57 deleted the enum-datatypes-implementation branch September 2, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guillaume-alliander guillaume-alliander Awaiting requested review from guillaume-alliander

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tom-hg57 @guillaume-alliander @HUG0-D