Checking containers on first run + cleanup#14
Open
michaelfarrow wants to merge 1 commit into
Open
Conversation
michaelfarrow
force-pushed
the
feature/check-on-first-run
branch
2 times, most recently
from
6e19505 to
a99ab6a
Compare
michaelfarrow
force-pushed
the
feature/check-on-first-run
branch
from
a99ab6a to
294ef6d
Compare
|
@allfro - This appears to solve a use case I've run into. Are you open to merging? |
|
@allfro This seems to be working really well, albeit for this issue which Michael has kindly submitted a PR for. Is there anything further needed that's preventing it being merged? Thanks! |
|
@michaelfarrow as this doesn't seem to be being merged, could you post your fork to dockerhub or ghcr for ease of access |
Author
|
@fma965 It's on dockerhub here: https://hub.docker.com/r/weyforth/device-mapping-manager |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this image is run after other stacks / containers, it won't fix the required devices as it only listens for newly running containers. This is likely to happen if restarting a swarm host.
This change adds an initial check of all running containers on first run.
Also cleaned up import order.
PS. My first time using go, sorry for any mistakes 😬