Fix: Corrected Found/Total count order and fixed text wrapping issue#560
Open
sammykramer wants to merge 1 commit intoalienator88:mainfrom
Open
Fix: Corrected Found/Total count order and fixed text wrapping issue#560sammykramer wants to merge 1 commit intoalienator88:mainfrom
sammykramer wants to merge 1 commit intoalienator88:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts UI copy/layout for the “Orphaned Files” toolbar subtitle and updates the files list stats header to display counts in a “found/total” style.
Changes:
- Allow the “Remaining files and folders…” subtitle to wrap instead of truncating in the ZombieView toolbar.
- Update the FileListView stats header string to include “found” and swap the count order.
- Add a new localized format key for the updated stats header text.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Pearcleaner/Views/ZombieView/ZombieView.swift | Updates toolbar subtitle modifiers to prevent truncation and allow wrapping. |
| Pearcleaner/Views/FilesView/FileListView.swift | Changes the stats header text and count ordering. |
| Pearcleaner/Resources/Localizable.xcstrings | Adds a new localized format key for the updated stats header text. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+3109
to
+3117
| "%lld/%lld file%@ found" : { | ||
| "localizations" : { | ||
| "en" : { | ||
| "stringUnit" : { | ||
| "state" : "new", | ||
| "value" : "%1$lld/%2$lld file%3$@ found" | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
A new localized key (%lld/%lld file%@ found) was added with only an en localization. The previous format string had translations for many locales, so this change will regress localization for non-English users unless equivalent translations are added (or the existing translated key is reused/updated).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #554