fix(review-filter): add submit_filter_result func for review filter stage#295
fix(review-filter): add submit_filter_result func for review filter stage#295ScarletCarpet wants to merge 1 commit into
submit_filter_result func for review filter stage#295Conversation
2ffdf0e to
55bcd09
Compare
|
@lizhengfeng101 这里咨询下,为什么reviewfiletr不用tool_call的方式限制LLM的输出呢?保证LLM的注意力么? 修改:
|
55bcd09 to
90c919a
Compare
submit_filter_result func for review filter stage
… stage At review filter stage, LLM(test GLM5.2) may return natural language content such as: """ Looking at each comment... - commit 1: ... - commit 2: ... Summary: ```json [...]``` """ add function calling for LLM will get more stable result for some model of providers. and this tool only appears at review filter stage, so it does no harm for review quality.
90c919a to
8032c52
Compare
|
+1 — independent repro with the exact same model, and some data from the session store showing this bug has real output-affecting impact. Repro. v1.7.1 built from The verdicts were computed and lost. The session store keeps the full filter responses, and all 4 unparseable ones have the same shape — reasoning prose with a correct fenced JSON array as the last line: Three of the four lost verdicts were Two residual gaps you may want to cover here or in a follow-up (happy to send a PR for either):
|
thanks a lot for reveiwing! i'll try to do impromve the logic which you mentioned. |

fix(review-filter): add
submit_filter_resultfunc for review filter stageAt review filter stage, LLM(test GLM5.2) may return natural language content such as:
"""
Looking at each comment...
Summary:
json [...]"""
add function calling for LLM will get more stable result for some model of providers.
and this tool only appears at review filter stage, so it does no harm for review quality.
Description
Type of Change
How Has This Been Tested?
make testpasses locallyChecklist
go fmt,go vet)Related Issues