fix(cosh-ng): [shell] stabilize raw cli tests#1327
Closed
samchu-zsl wants to merge 1 commit into
Closed
Conversation
|
|
8914f8a to
a877f94
Compare
Keep raw mode semantics unchanged and move the fixes into the raw_cli harness and assertions. This preserves the shell-first runtime contract while making Linux, zsh, locale, git, and renderer differences explicit in tests. The remaining layout audit debt is documented separately because this patch avoids production module movement. Signed-off-by: shenglongzhu <samchu.zsl@alibaba-inc.com>
a877f94 to
e6d3f12
Compare
Collaborator
|
PR number: #1327 Findings
Open Questions
Validation
|
SunnyQjm
approved these changes
Jul 6, 2026
SunnyQjm
left a comment
Collaborator
There was a problem hiding this comment.
Approved. Existing review notes are treated as non-blocking for this PR.
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stabilizes the
cosh-shellraw CLI test suite without changing the shell runtime semantics. The patch keeps raw mode returning the final shell command status, and moves the fixes into test harness behavior and assertions so Linux, zsh, locale, git, and renderer differences are explicit in tests.This is a test-debt remediation change for
cosh-ng; production module boundaries and runtime behavior are intentionally left unchanged.Related Issue
no-issue: test debt remediation
Type of Change
Scope
cosh(copilot-shell)cosh-ng(cosh-ng)sec-core(agent-sec-core)skill(os-skills)sight(agentsight)tokenless(tokenless)ckpt(ws-ckpt)memory(agent-memory)anolisa(anolisa-cli)skillfs(SkillFS)Checklist
cosh: Lint passes, type check passes, and tests passcosh-ng:cargo clippy --all-targets -- -D warningsandcargo fmt --checkpasssec-core(Rust):cargo clippy -- -D warningsandcargo fmt --checkpasssec-core(Python): Ruff format and pytest passskill: Skill directory structure is valid and shell scripts pass syntax checksight:cargo clippy -- -D warningsandcargo fmt --checkpasstokenless:cargo clippy -- -D warningsandcargo fmt --checkpassmemory(Linux only):cargo clippy --all-targets -- -D warnings,cargo fmt --check, andcargo testpassanolisa:cargo clippy --all-targets --locked -- -D warnings,cargo fmt --all --check, andcargo test --lockedpassskillfs:cargo fmt --all --check,cargo clippy --workspace --all-targets -- -D warnings, andcargo test --workspacepasspackage-lock.json/Cargo.lock)Testing
cargo fmt --package cosh-shell --all -- --checkgit diff --checkgit diff --cached --checkcargo test --package cosh-shell --lib(638 passed; 0 failed)cargo test --package cosh-shell --test logic(5 passed; 0 failed)cargo test --package cosh-shell --test protocol(21 passed; 0 failed)cargo test --package cosh-shell --test shell_host -- --test-threads=4(37 passed; 0 failed; 1 ignored)cargo test --package cosh-shell --test raw_cli -- --nocapture(301 passed; 0 failed; 1 ignored)Additional Notes
crates/cosh-shell/scripts/check-layout.shstill reports existing layout debt unrelated to this tests-only patch: rootsrc/logging.rs, large production files, and source heavy-test risk.no-issueis acceptable or provides an issue number.