fix(agent-sec-core): override loongshield exit 0 on error + actionable ErrManifestMissing#1282
Open
zhangtaibo wants to merge 1 commit into
Open
Conversation
…e ErrManifestMissing Fixes alibaba#1280: HardeningBackend passthrough of loongshield exit 0 when the tool encounters errors (invalid config, reinforce without root) causes CLI to falsely report success. Now detects [ERROR/ENFORCE-ERROR in output and overrides exit code to 1. Fixes alibaba#1281: ErrManifestMissing error message lacked actionable guidance. Now includes cause explanation and suggests sign-skill command. Verified on ECS: fresh clone + apply patch + rpm-build.sh -> exit 0, 7 RPMs produced. All 9 pytest cases pass. Co-Authored-By: Claude <noreply@anthropic.com>
|
zhangtaibo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
Fixes #1280
Fixes #1281
agent-sec-cli harden命令在调用loongshield后端时,HardeningBackend直接透传loongshield的 exit code。但loongshield在遇到配置文件缺失或非 root 用户执行 reinforce 时仍返回 exit 0,导致 CLI 误报成功。同时verify命令的ErrManifestMissing错误信息缺乏可操作性提示。修复
验证
Co-Authored-By: Claude noreply@anthropic.com