fix: upgrade deps to clear Trivy HIGH CVE blocking cloud image build#123
Merged
Conversation
POST /api/auth/register now requires acceptedTos + acceptedPrivacy when running in cloud mode (skipped on self-hosted). On success, recordConsent is called with source='signup' before any location auto-join so the audit trail orders consent first. The optional marketingOptIn is forwarded but only honored when MARKETING_OPT_IN_VISIBLE is true. Test helper createTestUser now sends both consent flags so existing tests that mock isSelfHosted()=false (planGating, downgrade, etc.) continue to satisfy the gate. Two direct register calls in accountDeletion.e2e.test.ts updated for the same reason.
- Extract <ConsentCheckboxes> shared component (used by RegisterPage and CompleteSignupPage; eliminates ~50 lines of duplicated checkbox JSX). - Add LEGAL_DOCUMENTS / LegalDocument / CONSENT_REQUIRED_CODE constants in legalVersions.ts and consume them in consent.ts, the migration, and requireCurrentConsent. - Loop tos/privacy in recordConsent and migration backfill instead of copy-paste; consolidate byte-identical SQLITE/POSTGRES CREATE_STATEMENTS. - Drop dead `req.consentVersions` global augmentation (zero readers). - Drop redundant SELECT in /api/auth/complete-consent — the client refetches /me right after, so we just confirm the recorded versions. - Fix CompleteSignupPage marketing opt-out: pass `marketingOptIn` directly instead of `marketingOptIn || undefined`, so unchecking on re-acceptance now opts the user out instead of silently preserving prior opt-in. - Drop noise comments (apiKeys cross-reference, register.ts narration, duplicate JSDoc on RecordConsentOptions, registerConsent.test.ts cross-reference, isReacceptance useMemo).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server/package.jsonandserver/package-lock.jsonTest Plan