Skip to content

Conversation

@ygrishajev
Copy link
Contributor

@ygrishajev ygrishajev commented Jan 20, 2026

refs #2475

Summary by CodeRabbit

  • New Features
    • Added a Port field to Build & Install Configurations so users can specify the deployment port for a service. Input is validated as a number and defaults to 3000 when empty; invalid entries are ignored. This enhances port configuration without changing existing form behavior.

✏️ Tip: You can customize this high-level summary in your review settings.

@ygrishajev ygrishajev requested a review from a team as a code owner January 20, 2026 13:09
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 20, 2026

📝 Walkthrough

Walkthrough

Adds a Port input to the Build & Install Configurations in RemoteBuildInstallConfig, showing currentService.expose[0].port and updating services.0.expose.0.port on change, coercing to a number and defaulting to 3000 for falsy values; non-numeric inputs are ignored.

Changes

Cohort / File(s) Summary
Port Configuration UI
apps/deploy-web/src/components/remote-deploy/deployment-configurations/RemoteBuildInstallConfig.tsx
Adds a BoxTextInput for services.0.expose.0.port; reads currentService.expose[0].port, coerces input to Number (defaults to 3000 when falsy), and ignores invalid numeric input.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • stalniy
  • baktun14

Poem

🐰 A port field hops into view,
I nudge the number, steady and true,
If blank or fuzzy, I default to three thousand,
Configs aligned, the deploy road unbounden,
🥕📦🚀

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding port configuration UI to the build and deploy feature.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.43%. Comparing base (48b4e5f) to head (a72364e).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...oyment-configurations/RemoteBuildInstallConfig.tsx 0.00% 6 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (79.35%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2539      +/-   ##
==========================================
- Coverage   50.73%   50.43%   -0.31%     
==========================================
  Files        1063     1053      -10     
  Lines       29513    29170     -343     
  Branches     6541     6506      -35     
==========================================
- Hits        14973    14711     -262     
+ Misses      14187    14106      -81     
  Partials      353      353              
Flag Coverage Δ *Carryforward flag
api 79.35% <ø> (ø) Carriedforward from 48b4e5f
deploy-web 31.16% <0.00%> (-0.01%) ⬇️
log-collector ?
notifications 87.94% <ø> (ø) Carriedforward from 48b4e5f
provider-console 81.48% <ø> (ø) Carriedforward from 48b4e5f
provider-proxy 84.35% <ø> (ø) Carriedforward from 48b4e5f

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...oyment-configurations/RemoteBuildInstallConfig.tsx 0.00% <0.00%> (ø)

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ygrishajev ygrishajev merged commit da6ca50 into main Jan 20, 2026
65 of 67 checks passed
@ygrishajev ygrishajev deleted the feat/deployment branch January 20, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants