Make Services Available in Companion Bootstrapping#308
Draft
schrieveslaach wants to merge 14 commits intomasterfrom
Draft
Make Services Available in Companion Bootstrapping#308schrieveslaach wants to merge 14 commits intomasterfrom
schrieveslaach wants to merge 14 commits intomasterfrom
Conversation
schrieveslaach
force-pushed
the
services-in-bootstrap-args
branch
from
fd4b2ed to
26a02de
Compare
schrieveslaach
commented
Mar 3, 2026
|
|
||
| let app_name = deployment_unit.app_name(); | ||
| let app_name = &deployment_unit.app_name; | ||
| let bootstrapping_containers = self.config.companion_bootstrapping_containers( |
Contributor
Author
There was a problem hiding this comment.
thought: It feels like that the templating logic must move elsewhere and must be unified with the templating for static companions. For example, the configs_for_templating could be used for this purpose. I think I need to invest here and make a domain module that holds such logic independent of the infrastructure (like in the Hamburger-Architecture, see https://www.youtube.com/watch?v=RJ0k6_MgsN4)
schrieveslaach
force-pushed
the
services-in-bootstrap-args
branch
from
26a02de to
c957297
Compare
Work in progress implementation Fixes #304
schrieveslaach
force-pushed
the
services-in-bootstrap-args
branch
from
fc75702 to
017bf37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress implementation
Fixes #304