Add custom header support to websocket client - #4607
Draft
borysvorona wants to merge 7 commits into
Draft
Conversation
borysvorona
changed the title
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4607 +/- ##
==========================================
+ Coverage 97.50% 97.51% +0.01%
==========================================
Files 43 43
Lines 8988 8988
Branches 1418 1418
==========================================
+ Hits 8764 8765 +1
+ Misses 103 102 -1
Partials 121 121
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
psf-chronographer
Bot
added
the
bot:chronographer:provided
Member
Author
|
@asvetlov, could you review that? |
asvetlov
requested changes
Oct 16, 2020
asvetlov
left a comment
asvetlov
left a comment
Member
There was a problem hiding this comment.
I have a feeling that wrong headers are exposed
| autoclose, | ||
| autoping, | ||
| self._loop, | ||
| headers=real_headers, |
Member
There was a problem hiding this comment.
Are ws.headers for HTTP client headers sent to a server or server headers returned to the client back?
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
@borysvorona this needs rebasing + addressing the comments. Turning it into a draft for now. |
webknjaz
marked this pull request as draft
September 20, 2022 13:46
Dreamsorcerer
added
pr-unfinished
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add custom header support to ClientWebSocketResponse (#2053)
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.