🎨 Palette: Add contextual aria-labels to generic citation buttons#218
🎨 Palette: Add contextual aria-labels to generic citation buttons#218aicoder2009 wants to merge 1 commit into
Conversation
This commit adds explicit `aria-label` attributes to the generic visual text buttons (like `[copy]`, `[edit]`, `[share]`, `[delete]`, `[clear]`, `[+ add notes]`, `[+ add quote]`, `[+ add tag]`, `[remove]`, `[add]`, and `[cancel]`) in `src/components/wiki/sortable-citation.tsx`. It also conditionally updates the `aria-label` for buttons that change visual state (e.g., `[copy]` -> `[copied!]`) so screen reader users hear the accurate dynamic state context instead of generic repetitive labels. Co-authored-by: aicoder2009 <127642633+aicoder2009@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdds ChangesAccessibility labeling of citation buttons
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💡 What
Added explicit
aria-labelattributes to the generic visual text buttons (like[copy],[edit],[share],[delete],[clear],[+ add notes],[+ add quote],[+ add tag],[remove],[add], and[cancel]) insrc/components/wiki/sortable-citation.tsx. Also conditionally updatedaria-labels for buttons that change visual state (like[copy]->[copied!]).🎯 Why
Text buttons with simple labels might look visually acceptable in isolation, but when they appear multiple times within lists or components like
SortableCitation, screen reader users lose context (e.g., they just hear "edit, button, edit, button"). Providing contextual labels (e.g., "Edit citation") creates a significantly better experience.📸 Before/After
This is a non-visual accessibility improvement.
♿ Accessibility
This enhancement allows screen reader users to understand exactly which citation or note they are interacting with when tabbing through the interface, providing robust, specific context that was previously missing.
PR created automatically by Jules for task 17037669417749394547 started by @aicoder2009
Summary by CodeRabbit