feat: allow passing inputs_embeds - #28
Merged
Merged
Conversation
christofid
marked this pull request as draft
February 15, 2026 09:22
christofid
marked this pull request as ready for review
February 15, 2026 15:06
jannisborn
requested changes
Feb 16, 2026
jannisborn
left a comment
jannisborn
left a comment
Contributor
There was a problem hiding this comment.
Great job especially tests are very thorough, I think I spotted some traces of outdated code on single-vs-multi-stage. Also left some cosmetic comments, please have a look @christofid
|
|
||
| def test_inputs_embeds_nested_multistage_currently_unsupported(self): | ||
| """ | ||
| Document current limitation: even with correctly nested inputs_embeds, |
| h_mblm, h_encoder, atol=1e-5 | ||
| ), "Encoder hidden states differ from MBLM after syncing weights" | ||
|
|
||
| def test_inputs_embeds_nested_multistage_currently_unsupported(self): |
| # This currently raises due to the rearrange(input_ids, ...) line in the implementation. | ||
| _ = mblm.forward(inputs_embeds=nested, return_type=MBLMReturnType.HIDDEN_STATE) | ||
|
|
||
| # NOTE: Consistency test makes sense only for single-stage. |
Contributor
There was a problem hiding this comment.
if the above is indeed outdated, we should test here also for multi-stage
Contributor
There was a problem hiding this comment.
this consistrency test is great overall!
Contributor
Author
There was a problem hiding this comment.
thanks a lot, I have cleaned up and updated this unit test
jannisborn
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow passing inputs_embeds in MBLM and MBLMEncoder