Skip to content

v3 quality pass: architectural refactor & bug fixes & lint cleanup #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ocean wants to merge 16 commits into
base: v3-candidate
Choose a base branch
from
Open

v3 quality pass: architectural refactor & bug fixes & lint cleanup #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
7b9fd89
fix: limit downloadFile() response body to 10 MB
ocean Jun 16, 2026
5c3d999
fix: declare GitCommit, GitBranch, BuildTime vars for ldflags injection
ocean Jun 16, 2026
c278995
fix: env-file vars now correctly override inherited env on macOS
ocean Jun 16, 2026
84bcd68
fix: move no-config Execute() call out of setupApp() into main()
ocean Jun 16, 2026
08279c9
fix: getConfig() error message names the failing file, not the root c…
ocean Jun 16, 2026
acaab16
fix: preserve bare -- end-of-options separator in normaliseLongFlagPr…
ocean Jun 16, 2026
e50df85
fix: delete dead PrintValidationIssues() function
ocean Jun 16, 2026
6b05c21
fix: compare pre-release version segments numerically, not lexicograp…
ocean Jun 16, 2026
86f9e1d
fix: Makefile install target uses $(BINARY_NAME) not hardcoded ahoy
ocean Jun 16, 2026
c6f1d76
fix: warn and skip malformed lines in env files (no KEY=VALUE separator)
ocean Jun 16, 2026
5c555e1
fix: appRun() test helper handles --file=value and -f=value flag forms
ocean Jun 16, 2026
58fb2fc
refactor: encapsulate package-level globals into appState struct (#5)
ocean Jun 16, 2026
d22c603
fix: add errNoConfig sentinel to getConfigPath (#6)
ocean Jun 16, 2026
c9000e1
test: add errNoConfig sentinel coverage to TestGetConfigPath
ocean Jun 16, 2026
cf7460a
fix: resolve golangci-lint errcheck, unconvert, staticcheck, and noct…
ocean Jun 16, 2026
7964d8f
chore: Remove detritus
ocean Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ default:
go build -ldflags $(LDFLAGS) -v -o ./$(BINARY_NAME)

install:
cp ahoy /usr/local/bin/ahoy
cp $(BINARY_NAME) /usr/local/bin/ahoy
chmod +x /usr/local/bin/ahoy

build_dir:
Expand Down
Loading