write: (name: string) -> Promise<mixed>#645
Open
krainboltgreene wants to merge 4 commits intoaheckmann:masterfrom
Open
write: (name: string) -> Promise<mixed>#645krainboltgreene wants to merge 4 commits intoaheckmann:masterfrom
krainboltgreene wants to merge 4 commits intoaheckmann:masterfrom
Conversation
|
Hey I'd love to see Promise support for the I'm not a maintainer, but I review the code and I think the Promise support would better be optional:
Lots of libraries works like that. |
Author
|
The only failing bit is node 0.10, which frankly...it's way past lts. |
|
Came across this same problem and I agree with @ncuillery with the logic implementation. Quite a few libraries do handle it like that and it's intuitive to most users. In the meantime until this PR is accepted, an applicable solution is to promisify the function and save it in gm, like so. Just add it to the top of your code before running any code using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promises are a great form of handling concurrency where a single value is passed around. Instead of doing a callback, now users can chain then's or catch's.