fix: replace Timex with native timestamp casting#89
Merged
Conversation
Timex.parse(record, "{RFC3339}") requires a T separator between date
and time, but Postgres WAL pgoutput sends timestamps in space-separated
format (e.g. "2024-01-15 10:30:00.123456+00").
This meant timestamp and timestamptz columns were never actually cast
to DateTime. Native casting is also significantly faster and more
memory efficient.
adriencohen
force-pushed
the
fix/timestamp-casting
branch
from
45768ad to
ecad384
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timex.parse(record, "{RFC3339}")requires aTseparator between date and time, but Postgres WALpgoutputsends timestamps in space-separated format (e.g.2024-01-15 10:30:00.123456+00).This meant timestamp and timestamptz columns were never actually cast to DateTime. Native casting is also significantly faster and more memory efficient.