Skip to content

Fix postgresql array types parsing#84

Merged
cpursley merged 1 commit into
agoodway:masterfrom
FabienHenon:fix/array-parsing
Jul 21, 2025
Merged

Fix postgresql array types parsing#84
cpursley merged 1 commit into
agoodway:masterfrom
FabienHenon:fix/array-parsing

Conversation

@FabienHenon

Copy link
Copy Markdown
Contributor

When I use an array field in PostgreSQL I receive records as strings like this: {1,2,3} instead of Elixir arrays.

This PR aims to cast correctly float, integer and string arrays (handling quoted strings and unquoted strings).

@cpursley

Copy link
Copy Markdown
Collaborator

@FabienHenon ~ I took the liberty to extend your work and refactor all the type casting stuff, borrowing from Supabase realtime and Sequin: #85

Could you review this against your codebase if you can a moment?

@FabienHenon

Copy link
Copy Markdown
Contributor Author

@FabienHenon ~ I took the liberty to extend your work and refactor all the type casting stuff, borrowing from Supabase realtime and Sequin: #85

Could you review this against your codebase if you can a moment?

Sure!
I’m on holidays at the moment, but as soon as I have a moment I’ll review your refactor

@cpursley

cpursley commented Jul 21, 2025

Copy link
Copy Markdown
Collaborator

Enjoy your time off. I'm going to go ahead and cut a release and let me know when you're back and we can refine if necessary.

@cpursley cpursley merged commit b921dee into agoodway:master Jul 21, 2025
0 of 2 checks passed
@FabienHenon

Copy link
Copy Markdown
Contributor Author

Enjoy your time off. I'm going to go ahead and cut a release and let me know when you're back and we can refine if necessary.

I had some time to check and eveything is fine!

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants