Dev tooling updates#502
Merged
inFocus7 merged 14 commits intoMay 19, 2026
Merged
Conversation
Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
Comment on lines
+53
to
+54
| CRANE ?= $(GO_TOOL) crane | ||
| GCI ?= $(GO_TOOL) gci |
Collaborator
There was a problem hiding this comment.
Do we need either of these tool deps?
Collaborator
There was a problem hiding this comment.
We should be using the gci golangci-lint formatter instead of the direct tool dependency. That can be done in a follow-up though. You can see the commented out config already for enabling it.
Collaborator
Author
There was a problem hiding this comment.
Good calls, crane was unused, but I initially kept it (in case). I just removed it and the direct call to gci + crane usage.
on a relevant note: gci was originally called only modified files, but since it's now part of the golangci-lint flow it runs for all files. Some go import formatting came into my changes 👍🏼
Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
timflannagan
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates to the dev workflow
tools/folder to separate from root dependencies.make charts-docsREADME.md.gotmplfile, but it wasn't wired up to generate theREADME.md.lintworkflow step to use go tool instead of GH actiontools/go.sumto dependency caches in workflowsgciwithingolanci-lint** A lot of go imports where refactored due to the
gcisettings:Change Type
Changelog
Additional Notes
Verification based on workflows running successfully.
Another verification is simply running one of the tool-based make targets - such as
make lint- and see it work.