Skip to content

Dev tooling updates#502

Merged
inFocus7 merged 14 commits into
agentregistry-dev:mainfrom
inFocus7:cleanup/tooling-updates
May 19, 2026
Merged

Dev tooling updates#502
inFocus7 merged 14 commits into
agentregistry-dev:mainfrom
inFocus7:cleanup/tooling-updates

Conversation

@inFocus7
Copy link
Copy Markdown
Collaborator

@inFocus7 inFocus7 commented May 18, 2026

Description

Updates to the dev workflow

  1. Move tool dependencies to own tools/ folder to separate from root dependencies.
  2. Added Helm doc file generation via make charts-docs
    • There was a pre-existing README.md.gotmpl file, but it wasn't wired up to generate the README.md.
  3. Updated lint workflow step to use go tool instead of GH action
  4. Added tools/go.sum to dependency caches in workflows
  5. Using gci within golanci-lint*

* A lot of go imports where refactored due to the gci settings:

formatters:
  settings:
    gci:
      sections:
        - standard
        - default
        - localmodule

Change Type

/kind cleanup

Changelog

NONE

Additional Notes

Verification based on workflows running successfully.

Another verification is simply running one of the tool-based make targets - such as make lint - and see it work.

inFocus7 added 12 commits May 18, 2026 10:58
Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
@inFocus7 inFocus7 marked this pull request as ready for review May 19, 2026 12:25
@inFocus7 inFocus7 changed the title [WIP] Dev tooling updates Dev tooling updates May 19, 2026
@inFocus7 inFocus7 enabled auto-merge May 19, 2026 15:22
Copy link
Copy Markdown
Collaborator

@timflannagan timflannagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QQ on crane

Comment thread Makefile Outdated
Comment on lines +53 to +54
CRANE ?= $(GO_TOOL) crane
GCI ?= $(GO_TOOL) gci
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need either of these tool deps?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be using the gci golangci-lint formatter instead of the direct tool dependency. That can be done in a follow-up though. You can see the commented out config already for enabling it.

Copy link
Copy Markdown
Collaborator Author

@inFocus7 inFocus7 May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good calls, crane was unused, but I initially kept it (in case). I just removed it and the direct call to gci + crane usage.

on a relevant note: gci was originally called only modified files, but since it's now part of the golangci-lint flow it runs for all files. Some go import formatting came into my changes 👍🏼

inFocus7 added 2 commits May 19, 2026 13:29
Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
@inFocus7 inFocus7 added this pull request to the merge queue May 19, 2026
Merged via the queue into agentregistry-dev:main with commit 5ee8414 May 19, 2026
9 checks passed
@inFocus7 inFocus7 deleted the cleanup/tooling-updates branch May 19, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants