[CLIENT-3947] Deprecate meta["ttl"] parameter in favor of setting ttl as a policy option instead#880
Conversation
…accepting ttl as an option
…to aerospike.TTL_CLIENT_DEFAULT
…policy-ttl-not-working
…policy-ttl-not-working
…policy-ttl-not-working
…policy-ttl-not-working
…policy-ttl-not-working
…policy-ttl-not-working
…policy-ttl-not-working
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #880 +/- ##
==========================================
+ Coverage 83.53% 83.87% +0.33%
==========================================
Files 99 99
Lines 14392 14416 +24
==========================================
+ Hits 12022 12091 +69
+ Misses 2370 2325 -45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…Werror is set in python.
… get DECREF'd if the callback returns false
… policy or the deprecated meta ttl
3efad5b to
09dbac0
Compare
|
Build artifacts passes except for unrelated infra issues (Docker's dev branch now has the fix for macos arm64 runners failing) and Windows crash.
Massif memory usage looks ok New memory leak in this PR still being reported. No memory errors reported: Changes to test_remove.py aren't causing this memory leak. |
|
Going to ignore "possibly lost" memory leaks from now on, since it seems the only valid leaks that valgrind detects from CPython are "definitely lost" python/cpython#75675 Did a thorough investigation on the leak and could not narrow down the test case causing the leak |
This affects all the aerospike.Client methods that accept a metadata dictionary parameter:
client.remove(): deprecate the meta parameter in favor of setting the generation in the remove policy parameter
As well as BatchRecords Write and Read.
Known Issues (out of scope of this PR)
Code coverage report does not reflect -Werror flag. Need to file separate ticketThis is expected behaviorBreaking Changes
Extra Changes
Documentation
https://aerospike-python-client--880.org.readthedocs.build/en/880/client.html
TODO