MWPW-194184: Fix cancel on 2nd Generate redirecting to Firefly instead of a.com#768
Merged
Conversation
arugupta1992
approved these changes
May 6, 2026
Collaborator
|
Looks fine in the branch URL. |
…d of a.com Reset assetId in cancelUploadOperation so subsequent Generate calls re-upload the asset with proper AbortController support rather than skipping to continueInApp with a stale assetId and no cancellation hook. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…refly on Windows Two guards added to handle cancellation at every phase of the Generate flow: 1. continueInApp(): check promiseStack before redirect — prevents Firefly redirect when cancel fires during the connector POST (fast-network / Windows case where upload completes before the user clicks cancel). 2. uploadAsset(): check signal.aborted after asset-creation POST — closes a race where cancel fires during the signalless first POST, causing assetId to be re-set after cancelUploadOperation already nulled it, which would skip the upload on the next Generate and reproduce the original bug. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The handleVerbLinkClick beforeEach was passing the shared workflowCfg by reference, allowing tests that replace targetCfg to corrupt shared state and break subsequent tests that depend on limits being set. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
vipu0303
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-194184
Test URLs: