[MWPW-192608] Fix race condition in bulk publish v2 authentication#5901
Open
mokimo wants to merge 1 commit intoadobecom:stagefrom
Open
[MWPW-192608] Fix race condition in bulk publish v2 authentication#5901mokimo wants to merge 1 commit intoadobecom:stagefrom
mokimo wants to merge 1 commit intoadobecom:stagefrom
Conversation
Contributor
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
DKos95
approved these changes
May 6, 2026
Contributor
DKos95
left a comment
DKos95
left a comment
There was a problem hiding this comment.
Looks good to me, haven't been able to replicate the issue again.
Handle case where sidekick status-fetched event fires before listeners are registered, causing "open sidekick and sign in" prompt even when the sidekick is open and logged in. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
SilviuLCF
approved these changes
May 7, 2026
SilviuLCF
left a comment
SilviuLCF
left a comment
There was a problem hiding this comment.
Verified, testing details :https://jira.corp.adobe.com/browse/MWPW-192608
overmyheadandbody
approved these changes
May 7, 2026
Contributor
|
Reminder to set the |
robert-bogos
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix race condition in bulk publish v2 where the sidekick
status-fetchedevent fires before listeners are registered, causing users to see "open sidekick and sign in" even when the sidekick is already open and logged in.The fix extracts listener registration into an
addListenershelper and immediately checkssidekick.appStore?.statusafter attaching listeners to handle the case where the event already fired.Resolves: MWPW-192608
Test URLs:
🤖 Generated with Claude Code