Skip to content

MWPW-194063: Use unique X-Request-ID per outbound request in IO pipel…#830

Open
seanchoi-dev wants to merge 1 commit intomainfrom
MWPW-194063
Open

MWPW-194063: Use unique X-Request-ID per outbound request in IO pipel…#830
seanchoi-dev wants to merge 1 commit intomainfrom
MWPW-194063

Conversation

@seanchoi-dev
Copy link
Copy Markdown
Contributor

…ine; propagate pipeline ID via X-Correlation-ID

Resolves https://jira.corp.adobe.com/browse/MWPW-194063
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases

Please do the steps below before submitting your PR for a code review or QA

  • C1. Cover code with Unit Tests
  • C2. Add a Nala test (double check with #fishbags if nala test is needed)
  • C3. Verify all Checks are green (unit tests, nala tests)
  • C4. PR description contains working Test Page link where the feature can be tested
  • C5: you are ready to do a demo from Test Page in PR (bonus: write a working demo script that you'll use on Thursday, you can eventually put in your PR)
  • C.6 read your Jira one more time to validate that you've addressed all AC's and nothing is missing

🧪 Nala E2E Tests

Nala tests run automatically when you open this PR.

To run Nala tests again:

  1. Add the run nala label to this PR (in the right sidebar)
  2. Tests will run automatically on the current commit
  3. Any future commits will also trigger tests as long as the label remains

To stop automatic Nala tests:

  • Remove the run nala label

Note: Tests only run on commits if the run nala label is present. Add the label whenever you need tests to run on new changes.

Test URLs:

…ine; propagate pipeline ID via X-Correlation-ID
@seanchoi-dev seanchoi-dev requested a review from a team May 5, 2026 06:31
@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented May 5, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.49%. Comparing base (d482aeb) to head (d807413).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #830      +/-   ##
==========================================
- Coverage   87.50%   87.49%   -0.01%     
==========================================
  Files         214      214              
  Lines       63850    63850              
==========================================
- Hits        55870    55865       -5     
- Misses       7980     7985       +5     

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d482aeb...d807413. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -38,7 +38,6 @@ async function main(params) {
Accept: 'application/json, */*',
'Accept-Encoding': 'gzip, deflate',
'User-Agent': 'Mozilla/5.0 (compatible; mas-io-Pipeline/1.0)',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we could have here
'X-Correlation-ID': context.requestId,

since it is a default header and ensures all fetches will have them

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree we could just have one line more here, and not +5 -1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants