MWPW-194063: Use unique X-Request-ID per outbound request in IO pipel…#830
MWPW-194063: Use unique X-Request-ID per outbound request in IO pipel…#830seanchoi-dev wants to merge 1 commit intomainfrom
Conversation
…ine; propagate pipeline ID via X-Correlation-ID
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
Commits
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #830 +/- ##
==========================================
- Coverage 87.50% 87.49% -0.01%
==========================================
Files 214 214
Lines 63850 63850
==========================================
- Hits 55870 55865 -5
- Misses 7980 7985 +5 see 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| @@ -38,7 +38,6 @@ async function main(params) { | |||
| Accept: 'application/json, */*', | |||
| 'Accept-Encoding': 'gzip, deflate', | |||
| 'User-Agent': 'Mozilla/5.0 (compatible; mas-io-Pipeline/1.0)', | |||
There was a problem hiding this comment.
nit: we could have here
'X-Correlation-ID': context.requestId,
since it is a default header and ensures all fetches will have them
There was a problem hiding this comment.
i agree we could just have one line more here, and not +5 -1
…ine; propagate pipeline ID via X-Correlation-ID
Resolves https://jira.corp.adobe.com/browse/MWPW-194063
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases
Please do the steps below before submitting your PR for a code review or QA
🧪 Nala E2E Tests
Nala tests run automatically when you open this PR.
To run Nala tests again:
run nalalabel to this PR (in the right sidebar)To stop automatic Nala tests:
run nalalabelTest URLs: