Ungated guide content type update#354
Open
jsandland wants to merge 170 commits into
Open
Conversation
* Rollout a page without a loc project * Rollout to langstore/en * Rollout to locales from langstore/XYZ * Ability to de-select regions * Can link out to pages before rollout
Upgrade da-bacom to hlx5
Consume stage again
Attempting to move back to file-based configs.
Sync Main
…ilities. Confirmed that all npm scripts work as expected (#7)
[Release] Stage to Main
* fix: content type to directory path mapping in landing page builder * update nala tests and cleanup script
* Add progressive profiling test automation to da-bacom Move progressive profiling tests from nala repo to da-bacom using the co-located 3-file pattern (spec + page object + test). Covers 10 test cases: - Unknown user field visibility (Short, Medium, RFI forms) - Journey tests (Short→Medium, Short→RFI, Medium→RFI) - Form submission tests (all 3 form types) - Edge case: cookie-cleared user reset Made-with: Cursor * Update progressive profiling automation * Add progressive profiling run guide * Trim progressive profiling README intro * remove this.companyType
* decouple ISWA typography from animated-photo-banner, drive via metadata * moves iswa.css into styles.css * indentation fix * adds iswa tests
* removing iswa classes on photo banner * A few more
* Adds some styles for our ceros implementation * Remove unset
The milolibs query param was interpolated directly into template literals used for dynamic import()s, letting an attacker point module loading at an arbitrary origin and execute JS in the page context. Add a strict whitelist (^[a-zA-Z0-9_-]+$) and throw on invalid input in head.html and scripts/scripts.js. Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
jsandland
requested review from
Brandon32,
JasonHowellSlavin and
meganthecoder
as code owners
|
* Placements for ctas * Removing cta placement code * 104px as requested
* Small changes for readability * Small changes for readability
…Bacom space (#164) * Adding Stream app * Update figma.html * Fix missing newline at end of daUtils.js Add newline at the end of daUtils.js file
* feat: add quickedit * Update quick-edit.js Co-authored-by: Brandon Marshall <kem5brandon@gmail.com> * Update quick-edit.js --------- Co-authored-by: Brandon Marshall <kem5brandon@gmail.com>
* add asset headline field to LPB for gated content types * add nala e2e tests * ensure h2 populates above pdf
…ted Guide gating Resolved conflicts in form-sections.js, landing-page.test.html, and the Nala test/spec files. Asset Headline tests stay at features[29-32]; Guide Gating tests renumbered to features[41-44] (tcids updated in spec.js) to avoid collisions with the Content Type Path suite (33-40). Also fixed lint errors in merged stage files: undefined searchParams in scripts.js, missing newline in quick-edit.js, and quote/comma/dot-notation issues in daUtils.js.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-192097
Test URLs:
DA (LPB) Test URLs: