fix: L2 correctness fixes split from loop-engineering (evals, publish gate, guard, env) - #23
Merged
Conversation
…ublish gate, guard, env)
Cherry-set of the pure bug-fix layer from feat/loop-engineering-v3, split out
per adversarial review so fixes are not bundled with loop automation infra:
- tools/publish_gate.sh: NUL-delimited staged-file loop — the previous
`for f in $FILES` word-split let a secret in a spaced filename exit CLEAN
(P1; functionally re-proven: spaced-filename ghp_ token now BLOCKS exit 1)
- 03-evals/src/eval_{corrective,ocr,planner}.py: diagnostics interpolate the
resolved Neo4j URI instead of hardcoded bolt://localhost:7688
- 03-evals/{golden_v1_review.md,src/{golden_v1_draft,test_g3,h3_instr}.py}:
stale claims corrected (6 roles -> 3 roles; docstring drift)
- tools/run_guard.py: self_test docstring matches ALLOWLIST-exemption behavior
(GUARD_SELFTEST_OK)
- 01-context/setup_a2.sh: pin neo4j-graphrag
- .env.example: correct Neo4j/paperclip facts; add LANGFUSE_HOST/BG_EMBED_MODEL
- .gitignore: ignore .claude/lessons.md (local working notes)
Loop scheduler/heartbeat/rulesets stay on the feature branch (PR #21/#22).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
adithya0597
added a commit
that referenced
this pull request
Jul 21, 2026
… infra parked, OAuth rewire, deadlock warning Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pure bug-fix layer split out of
feat/loop-engineering-v3(per adversarial review: fixes should not be bundled with loop-automation infra). No workflows, no rulesets, no loops/ — those stay on the feature branch (#21/#22).tools/publish_gate.sh(P1, security-relevant) — NUL-delimited staged-file loop. The previousfor f in $FILESword-split meant a secret inside a filename containing a space exited CLEAN. Functionally re-proven on this branch: a spaced-filenameghp_…token now BLOCKS (exit 1); clean surface stays CLEAN (exit 0).03-evals/src/eval_{corrective,ocr,planner}.py— diagnostics print the resolved Neo4j URI instead of hardcodedbolt://localhost:7688.03-evals/docs/tests (golden_v1_review.md,golden_v1_draft.py,test_g3.py,h3_instr.py) — stale claims corrected (6 roles → 3 roles; docstring drift).tools/run_guard.py— self_test docstring matches ALLOWLIST-exemption behavior (GUARD_SELFTEST_OK).01-context/setup_a2.sh— pinneo4j-graphrag..env.example— correct Neo4j/paperclip facts; addLANGFUSE_HOST/BG_EMBED_MODEL..gitignore— ignore.claude/lessons.md(local working notes).Verification (run locally on this branch)
bash -nboth shell scripts;ast.parseall 6 Python files — clean"my secret file.txt"containing aghp_token →publish gate: BLOCKEDexit 1; negative control →CLEANexit 0python3 tools/run_guard.py --self-test→GUARD_SELFTEST_OKbash tools/publish_gate.shover the staged 12-file surface →CLEANfeat/loop-engineering-v3versions (git diffempty)Merge note
Solo repo: classic branch protection requires 1 approval — merge with
gh pr merge --admin(founder). Do not apply the loop-merge-gates ruleset before merging this: it requirespublish-gate/pr-classifiedchecks whose workflow files exist only on the feature branch → would deadlock this PR.🤖 Generated with Claude Code