Skip to content

CMake: update minimum cmake version to avoid warnings#87

Closed
theodoregoetz wants to merge 1 commit intoadishavit:masterfrom
theodoregoetz:fix-cmake-warning
Closed

CMake: update minimum cmake version to avoid warnings#87
theodoregoetz wants to merge 1 commit intoadishavit:masterfrom
theodoregoetz:fix-cmake-warning

Conversation

@theodoregoetz
Copy link
Copy Markdown

CMake 3.27 issued a deprecation warning saying cmake <3.5 would no longer be supported.

closes #86

@adishavit
Copy link
Copy Markdown
Owner

Thank you.
Could you make the change without the indent/space diff, so that the diff contains only the cmake version change?

CMake 3.27 issued a deprecation warning saying cmake <3.5 would no longer
be supported.

closes adishavit#86
@theodoregoetz
Copy link
Copy Markdown
Author

fixed. sorry about that!

Copy link
Copy Markdown
Owner

Thanks for the PR! This has been superseded by #93, which addresses the same issue more completely using the VERSION 3.14...4.0 range syntax — the canonical modern solution that handles current and future CMake compatibility in one go. Closing this in favour of that one.


Generated by Claude Code

@adishavit adishavit closed this Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CMake deprecation warning with cmake <3.5

3 participants