Fix: Include themeVariables in preview cache key#205
Merged
Conversation
01afaf0 to
091c4ad
Compare
|
🎉 This PR is included in version 3.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #204
Fix
varsHashcomponent to the preview prebuilt cache key — a deterministic 12-char hash overthemeVariablesandcustomStyle— so two courses sharing the same(pluginHash, theme, menu)but with different presets or custom LESS no longer collide on the cache.course.databeforepreBuildHook/applySchemaDefaultsmutate it, so the same course consistently produces the same hash across runs. This also matches the eager prebuild's "no customisation" view, so default-themed real courses correctly share its cache entry.BuildCache.{getPath,has,populate,restore}to take and append thevarsHashto the cache directory name.prebuildCacheto populate with the hash of empty inputs (DEFAULT_VARS_HASH).Testing
node --experimental-test-module-mocks --test 'tests/**/*.spec.js'passes (28 tests, including newutils-computeVarsHash.spec.jsand extendedBuildCache.spec.js).npx standardis clean.