Cast message to MessageType before creating StreamChunk in stream_broadcaster#311
Open
TheRealNeil wants to merge 1 commit intoactiveagents:mainfrom
Open
Cast message to MessageType before creating StreamChunk in stream_broadcaster#311TheRealNeil wants to merge 1 commit intoactiveagents:mainfrom
TheRealNeil wants to merge 1 commit intoactiveagents:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cast message to MessageType before creating StreamChunk in stream_broadcaster
Fixes #307
Summary
MessageTypeinstream_broadcasterso thatchunk.messagehas the same typed interface asresponse.messageRoot cause
During streaming,
StreamChunk#messagewraps the raw Hash from the provider's message stack — no type casting is applied. After generation completes,PromptResponse#messagesare cast throughTypes::MessagesTypeintoCommon::Messages::*objects with method accessors (.content,.role).This means
chunk.message.contentraisesNoMethodErrorduring streaming, whileresponse.message.contentworks fine after generation. Users have to usechunk.message[:content]during streaming butresponse.message.contentafterwards — an inconsistent API.Fix
In
stream_broadcaster, cast the message throughProviders::Common::Messages::Types::MessageTypewhen it's a Hash before passing it toStreamChunk.new. This giveschunk.messagethe same typed interface asresponse.message, so.contentand.rolework consistently in both streaming and non-streaming contexts.Test plan
chunk.message.contentworks inon_streamcallbackschunk.message.roleworks inon_streamcallbacksresponse.message.contentis unaffected