feat: Fetch Inventory Config file from remote repository#2874
Closed
dijanin-brat wants to merge 4 commits intomasterfrom
Closed
feat: Fetch Inventory Config file from remote repository#2874dijanin-brat wants to merge 4 commits intomasterfrom
dijanin-brat wants to merge 4 commits intomasterfrom
Conversation
pxrl
reviewed
Jan 13, 2026
| RUN yarn | ||
|
|
||
| RUN yarn build | ||
| RUN yarn update-inventory-config |
Collaborator
There was a problem hiding this comment.
@dijanin-brat For the address filter, we run as a part of the postinstall target. Is there a reason we want to do update-inventory-config here vs. there?
Contributor
Author
There was a problem hiding this comment.
The only thing why i moved it here is that, if we put it in postinstall it will not work if someone does yarn install locally and doesn't have GITHUB_TOKEN ENV setup. That is basically the only reason to move it here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to fetch Inventory Config from remote repository during build time so that relayer can use it later.