Open
Conversation
esttorhe
reviewed
Nov 29, 2018
| return nil | ||
| } | ||
| #else | ||
| func callback(x: UnsafeMutableRawPointer?) -> UnsafeMutableRawPointer? { |
There was a problem hiding this comment.
I know that this repo is not mine or anything; but as seeing that the code inside the Linux path doesn't contain stuff that would fail compiling on macOS; wouldn't it be better to have something like macOSCallback and linuxCallback and then only applying the filtering inside of callback:
func callback(x: UnsafeMutableRawPointer?) -> UnsafeMutableRawPointer? {
#if(OSX)
return macOSCallback(x)
#else
return linuxCallback(x)
#endif
}Edit: I think this would make it more readable; happy to discuss if this is not true or doesn't make sense or even if it really doesn't add any value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this pull request fixes errors that are occurring when compiling in Linux
Thanks to @jakeheis for his fork
I haven't tested it on macOS