Skip to content

fix(update): use npm ci to prevent stale node_modules after update #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ceotjoe wants to merge 1 commit into
base: Staging
Choose a base branch
from
Open

fix(update): use npm ci to prevent stale node_modules after update #960

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions scripts/update.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,12 +223,14 @@ done

echo ""
echo "📦 Installing dependencies..."
# --include=dev ensures vite is installed even if NODE_ENV=production.
# npm ci deletes node_modules and reinstalls from the lockfile exactly,
# preventing stale packages from surviving across updates (e.g. a newly added
# production dependency not appearing in an existing node_modules tree).
# --ignore-scripts skips postinstall hooks that fail on Linux/Pi (e.g.
# electron-winstaller copying Windows-only binaries).
# ELECTRON_SKIP_BINARY_DOWNLOAD=1 avoids downloading the ~200 MB Electron
# binary which is not needed for the server/kiosk build.
ELECTRON_SKIP_BINARY_DOWNLOAD=1 npm install --include=dev --ignore-scripts
ELECTRON_SKIP_BINARY_DOWNLOAD=1 npm ci --ignore-scripts

echo ""
echo "📦 Downloading vendor assets..."
Expand Down
Loading