fix(update): use npm ci to prevent stale node_modules after update#959
Closed
ceotjoe wants to merge 13 commits intoaccius:Stagingfrom
Closed
fix(update): use npm ci to prevent stale node_modules after update#959ceotjoe wants to merge 13 commits intoaccius:Stagingfrom
ceotjoe wants to merge 13 commits intoaccius:Stagingfrom
Conversation
Removed macOS Intel build configuration and adjusted conditions for the publish job.
…modules npm ci deletes node_modules and reinstalls from the lockfile exactly, so newly added production dependencies (e.g. rss-parser in v26.3.x) are guaranteed to be present after an update rather than silently absent from an existing, incremental node_modules tree. Fixes: Cannot find module 'rss-parser' after running update.sh Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Will be newly created. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm install --include=devwithnpm ciinscripts/update.shnpm ciwipesnode_modulesbefore installing, so newly added production dependencies (likerss-parserin v26.3.x) are guaranteed to be present after an updateupdate.shleftrss-parserabsent, causing[FATAL] Cannot find module 'rss-parser'on service restart; re-runningsetup-pi.sh(which writes into a clean tree) resolved itTest plan
update.shon a Pi with an existing install from beforerss-parserwas added and confirm the service starts cleanlynpm cifails fast ifpackage.jsonandpackage-lock.jsonare out of sync (expected safety net behaviour)🤖 Generated with Claude Code