ci: GHA workflow security cleanup#2
Merged
Conversation
Set persist-credentials: false on actions/checkout so the default GITHUB_TOKEN is not left in the local git config after checkout.
Default both workflows to 'permissions: {}' and grant each job only
the GITHUB_TOKEN scopes it actually needs (contents: read for CI,
contents: write for the release job that publishes assets).
Release jobs publish artifacts and run on tag pushes, so a poisoned Go module cache restored from an earlier run could influence what gets shipped. Disable caching on actions/setup-go in the release workflow; CI test runs keep caching enabled.
Pin actions/checkout, actions/setup-go, and goreleaser-action to the commit SHA their current major-version tag points to, with the tag preserved as a comment. Prevents an upstream tag move from silently changing what runs in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routine hygiene pass over the GitHub Actions workflows in this repo, addressing findings from a workflow security audit. Changes are split into four commits, one per finding type:
the release job that publishes assets).
No behavioural changes intended — the workflows run the same checks against the same inputs.