Add UTS tests for LiveObjects path-based API#2219
Draft
paddybyers wants to merge 10 commits into
Draft
Conversation
Translate portable UTS test specs from specification/uts/objects/ into working ably-js TypeScript tests covering PathObject, Instance, batch operations, LiveCounter/LiveMap CRDT internals, ObjectsPool sync state machine, RealtimeObject lifecycle, value types, and subscriptions. 19 test files: 14 unit (270 tests), 4 integration (15 tests), 1 proxy fault injection (5 tests). 1 test pending (LiveMap#clear() not yet implemented). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 task
Remove client-side port allocation (TOCTOU race) and let the proxy auto-assign free ports via OS. Read the assigned port from the session creation response. Update binary to v0.2.0 with new asset naming. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adds parentReferences, PublicAPI::ObjectMessage, RTO24/25/26 tests; updates objectMessage/subscription assertions; removes batch API tests. 308 passing, 4 pending deviations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Mirrors specification commit e77bdb80. The GC integration test used fake timers (ADVANCE_TIME) which don't affect the sandbox server. Unit tests at RTO10 and RTLM19 already cover the same scenarios. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Mirrors specification commits add9398a and 3ad5a416. - Remove RTLM24 (clear() sends MAP_CLEAR) placeholder — test removed from UTS as spurious. - Remove RTLCV3c (no validation at creation time) — test removed from UTS as unnecessary. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Mirrors specification commit 8f524477. The UTS spec now uses serial "02"
with zero increment for the noop test (RTLO4b4c1). However, ably-js
doesn't implement RTLC9h (number=0 still returns a LiveCounterUpdate,
not a noop), so we use serial "01" with counterInc:{} (no number field)
which triggers the newness check rejection instead. Documented as a
deviation.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Mirrors specification commit d7d75e78. Instead of accessing internal _siteTimeserials, verify through observable side effects: after apply-on-ACK, send an inbound message from the same siteCode with an older serial. If LOCAL incorrectly wrote to siteTimeserials, the newness check rejects the inbound message (score stays 110 instead of reaching 120). Uses serial "t:0:0" to avoid appliedOnAckSerials dedup. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Mirrors specification commit e3614cd9. Instead of just asserting
score == 100 after re-sync (which proves nothing since OBJECT_SYNC
resets the pool regardless), replay the previously-applied ACK serial
("t:1:0") after re-sync. If appliedOnAckSerials was properly cleared,
the replayed message applies normally and score reaches 110.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Mirrors specification commit eaa69837. Each integration test now runs twice — once with JSON (useBinaryProtocol: false) and once with msgpack (useBinaryProtocol: true) — per the G1 data-path requirement. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Mirrors specification commit 86e96366. The UTS spec now expects error.cause.code == 90000, but ably-js throws 90001 (invalid channel state) without a .cause property. Updated the deviation comment to note the additional assertion difference. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
specification/uts/objects/into 290 working ably-js TypeScript testsLiveMap#clear()not yet implemented in ably-js)Test plan
npx mocha --no-config --require tsx/cjs 'test/uts/objects/**/*.test.ts' --timeout 60000🤖 Generated with Claude Code