Skip to content

add README banner image#412

Merged
AndyTWF merged 1 commit into
mainfrom
readme-image
Jun 12, 2026
Merged

add README banner image#412
AndyTWF merged 1 commit into
mainfrom
readme-image

Conversation

@AndyTWF

@AndyTWF AndyTWF commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Adds a README banner for the CLI

@vercel

vercel Bot commented Jun 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cli-web-cli Ready Ready Preview, Comment Jun 11, 2026 9:23am

Request Review

@AndyTWF AndyTWF requested a review from umair-ably June 11, 2026 09:22
@AndyTWF AndyTWF marked this pull request as ready for review June 11, 2026 09:22
@claude-code-ably-assistant

Copy link
Copy Markdown

Walkthrough

This PR adds a visual banner image to the top of the README. A new PNG file (images/cli-github.png) is added to the repository, and four lines are prepended to README.md to display it — the image, a horizontal rule, and a blank line separator before the existing heading.

Changes

Area Files Summary
Docs README.md Prepends banner image and horizontal rule before the existing title
Other images/cli-github.png New binary asset: the banner image displayed at the top of the README

Review Notes

  • Binary asset: The PNG is committed directly to the repo. No CI or build impact, but worth confirming the file size is reasonable for a README asset.
  • No breaking changes — purely additive documentation change.
  • No test coverage needed — static asset and markdown only.

@sacOO7

sacOO7 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

I asked gemini pro to do banner review, it mentioned following issues

  1. Dueling Aesthetics: The left side is an abstract, marketing-style graphic (dark gradient with red angled slashes). The right side is a literal, gritty terminal window complete with ASCII art. These two styles fight for dominance rather than complementing each other.
  2. The Problematic Overlap: The central app icon (>_) is intended to bridge the two halves, but it ends up making things worse. It has a heavy, muddy drop-shadow that blends poorly with the background, and worse, it physically obscures the actual CLI commands on the right. When text is meant to be read but is covered up, it creates immediate visual frustration.
  3. Redundancy: The banner communicates "Command Line Interface" three separate times: the text "Ably CLI," the central terminal icon, and the literal terminal screenshot. This makes the space feel crowded.

@sacOO7 sacOO7 self-requested a review June 11, 2026 10:04
@AndyTWF

AndyTWF commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

I asked gemini pro to do banner review, it mentioned following issues

  1. Dueling Aesthetics: The left side is an abstract, marketing-style graphic (dark gradient with red angled slashes). The right side is a literal, gritty terminal window complete with ASCII art. These two styles fight for dominance rather than complementing each other.
  2. The Problematic Overlap: The central app icon (>_) is intended to bridge the two halves, but it ends up making things worse. It has a heavy, muddy drop-shadow that blends poorly with the background, and worse, it physically obscures the actual CLI commands on the right. When text is meant to be read but is covered up, it creates immediate visual frustration.
  3. Redundancy: The banner communicates "Command Line Interface" three separate times: the text "Ably CLI," the central terminal icon, and the literal terminal screenshot. This makes the space feel crowded.

I've asked design to take a look at the comments and make an updates they feel necessary, but will merge this for now.

@AndyTWF AndyTWF enabled auto-merge June 11, 2026 11:51

@sacOO7 sacOO7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.
Lgtm

@AndyTWF AndyTWF disabled auto-merge June 12, 2026 10:41
@AndyTWF AndyTWF merged commit adfa1fe into main Jun 12, 2026
18 of 23 checks passed
@AndyTWF AndyTWF deleted the readme-image branch June 12, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants